Fix cloud_identity_group_membership to properly handle 403 responses #5103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applying fix from GoogleCloudPlatform/magic-modules#6999
The previous fix was deemed to be correct, but the tests caused our build to panic on subsequent PRs. As a mitigation, the original PR was reverted: GoogleCloudPlatform/magic-modules#7032. It appears that this was happening because the test creates a service account out-of-band that is not recorded or replayed in VCR mode. This led to the service account getting created on each replay, but not deleted, and ultimately produced an error that the service account already existed.
The resolution here is simply to skip this test for VCR mode. I was unable to come up with a way to perform this test without the out-of-band service account, and trying to manage that service account during VCR runs became brittle.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7089